[Dnsmasq-discuss] [PATCH] Add run-time option to disable CHAOS TXT records

[Simon Kelley]

Patch applied. As this is a low-complexity change, it has gone into the 
2.89 release.

I've tagged 2.89test1, as a move towards that.


Cheers,

Simon.


On 18/01/2023 03:24, Dominik Derigs wrote:
> Hey Simon,
> 
> totally an oversight on my side. Updated patch attached.
> 
> Best
> Dominik
> 
> On Mon, 2023-01-16 at 22:46 +0000, Simon Kelley wrote:
>> The patch moves the relevant code to after processing of command-line
>> arguments, but not reading configuration file(s). I can't think of any
>> reason why you wouldn't want to put
>>
>> no-ident
>>
>> into /etc/dnsmasq.conf
>>
>> Have I missed something?
>>
>>
>> Cheers,
>>
>> Simon.
>>
>>
>>
>> On 15/01/2023 08:01, Dominik Derigs wrote:
>>>
>>> Hey Simon and Petr, CC list,
>>>
>>> Thanks for pointing this out. I fixed it and rebased on
>>> latest master. New patch attached.
>>>
>>> The name "--no-ident" has been chosen as the corresponding
>>> compile-time option is called NO_ID - my feeling is that
>>> this corresponds to "no identification (strings)".
>>>
>>> I thought about adding the possibility to only disable a
>>> subset of these CHAOS records but it seems to just add to
>>> much code complexity for such a small feature. Hence a "all
>>> or nothing" seems the best fit for me here.
>>>
>>> Best,
>>> Dominik
>>>
>>> On Tue, 2023-01-03 at 10:48 +0000, Petr Menšík wrote:
>>>> Hi Dominik,
>>>>
>>>> Good idea. But there is copy&paste error on line 572, no
>>>> help
>>>> description is changed for new option. What does --no-
>>>> ident stand for by
>>>> the way? Wouldn't be --no-chaos more descriptive? Should
>>>> we support
>>>> optional argument to disable only some parts of provided
>>>> records? For
>>>> example cache statistics might be restricted to localhost
>>>> only or
>>>> provided only by DBus, while version might be still useful
>>>> to report.
>>>>
>>>> Cheers,
>>>> Petr
>>>
>>>
>>> On Fri, 2022-12-23 at 12:54 +0100, Dominik Derigs wrote:
>>>> Dear mailing list members,
>>>>
>>>> In 2016, dnsmasq got the option to prevent serving the
>>>> server version, some statistics and even the used upstream
>>>> DNS servers to its clients. Compiling with -DNO_ID removes
>>>> the entire *.bind info structure. However, setting -DNO_ID
>>>> requires a (re-)compilation from source.
>>>>
>>>> This patch adds a new run-time option --no-ident to achieve
>>>> the same without the need for recompiling.
>>>>
>>>> I wish you some nice and hopefully relaxing Christmas days!
>>>>
>>>> Best regards,
>>>> Dominik
>>>
>