[Dnsmasq-discuss] dnsmasq page fault

[Simon Kelley]

I just pushed a putative fix. Apologies for missing this.

Simon.


On 10/11/2023 19:46, e9hack wrote:
> Hi,
> 
> I think tcp_init() must be execute outside of if (daemon->port != 0) {}. 
> I've two instances running. The crashing instance acts as dhcp server only.
> 
> Regards,
> Hartmut
> 
> Am 10.11.2023 um 20:15 schrieb Geert Stappers:
>> On Fri, Nov 10, 2023 at 07:41:59PM +0100, e9hack wrote:
>>> Hi,
>>>
>>> it looks like that commit 416390f9962e455769aa8ab6df0e105cae07ae55 (Add
>>> --max-tcp-connections option to make this dynamically configurable.) is
>>> incomplete.
>>
>> https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commitdiff;h=416390f9962e455769aa8ab6df0e105cae07ae55;hp=24804b7431f6ace109e91876aef859a751bf3147
>>
>>> It occurs a page fault in dnsmasc.c line 1050 (initialisation of
>>> daemon->tcp_pipes with -1).
>>
>>
>> Oops.
>>
>>> Regards,
>>> Hartmut
>>
>>
>> Thanks for reporting.
>>
>>
>> Groeten
>> Geert Stappers
> 
> 
> _______________________________________________
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss at lists.thekelleys.org.uk
> https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
>