[Dnsmasq-discuss] [PATCH] Fix potential memory leak

[Geert Stappers]

On Sat, Mar 02, 2024 at 05:03:01PM +0100, Geert Stappers wrote:
> On Fri, Mar 01, 2024 at 04:43:20PM -0500, Brian Haley wrote:
> > When a new IPv6 address is being added to a dhcp_config
> > struct, if there is anything invalid regarding the prefix
> > it looks like there is a potential memory leak.
> > ret_err_free() should be used to free it.
> > 
> > Signed-off-by: Brian Haley <haleyb.dev at gmail.com>
> > ---
> >  src/option.c | 6 +++---
> }  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/option.c b/src/option.c
> > index f4ff7c0..02be995 100644
> > --- a/src/option.c
> > +++ b/src/option.c
> } @@ -4034,7 +4034,7 @@ static int one_opt(int option, char *arg, char *errstr, char *gen_err, int comma
> >  			    ((((u64)1<<(128-new_addr->prefixlen))-1) & addrpart) != 0)
> >  			  {
> >  			    dhcp_config_free(new);
> > -			    ret_err(_("bad IPv6 prefix"));
> > +			    ret_err_free(_("bad IPv6 prefix"), new_addr);
> >  			  }
> >  			
> >  			new_addr->flags |= ADDRLIST_PREFIX;
> 
> Looks good to me
> 

New version of the patch is planned.

As an attempt to express that proposed patches get human attention.


Groeten
Geert Stappers
-- 
Silence is hard to parse