[Dnsmasq-discuss] [PATCH v1] Fix dependency in make install target

[Geert Stappers]

Hello Olaf,
(Mailinglist in the Cc:)

On Tue, Oct 17, 2023 at 10:59:29PM +0200, Geert Stappers wrote:
> On Mon, Oct 16, 2023 at 12:02:53PM +0200, Olaf Hering wrote:
> > The make target 'install-common' expects results from the target 'all'.
> > A 'make -j install' may fail because both targets are brought
> > up-to-todate in parallel.
> 
> Nice. Good catch.  Yeah, consider that a compliment.
> 
> And it doesn't matter that the sane way is
> 
>       make -j
>       sudo make install
> 
> 
> > As a result the final binary will not exist at
> > the time 'install-common' runs, because 'all' is not yet done.
> > 
> > Adjust the dependencies to update 'all' before processing 'install-common'.
> > 
> > Signed-off-by: Olaf Hering <olaf at aepfle.de>
> > ---
> >  Makefile | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index 48e8d3b..f279339 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -105,9 +105,9 @@ clean : mostly_clean
> >  	rm -f core */core
> >  	rm -f *~ contrib/*/*~ */*~
> >  
> > -install : all install-common
> > +install : install-common
> >  
> > -install-common :
> > +install-common : all
> >  	$(INSTALL) -d $(DESTDIR)$(BINDIR)
> >  	$(INSTALL) -d $(DESTDIR)$(MANDIR)/man8
> >  	$(INSTALL) -m 644 $(MAN)/dnsmasq.8 $(DESTDIR)$(MANDIR)/man8 
> > 
> 
> 
> I have an idea to save that patch.  It is probably thursday
> when I have time to "materialize" the idea.
> 

Only 53% did get materialized in oktober.


Please resend the patch to the dnsmasq mailinglist
and add
  Mailinglist patch collector <~stappers/dnsmasqmlpc at lists.sr.ht>
to the To: or Cc:



Regards
Geert Stappers
Wannabee Patch Collector
-- 
Silence is hard to parse