[Dnsmasq-discuss] [PATCH] Fix dependency in make install target

Geert Stappers stappers at stappers.nl
Wed Apr 17 20:03:42 UTC 2024


From: Olaf Hering <olaf at aepfle.de>

The make target 'install-common' expects results from the target 'all'.
A 'make -j install' may fail because both targets are brought
up-to-todate in parallel. As a result the final binary will not exist at
the time 'install-common' runs, because 'all' is not yet done.

Adjust the dependencies to update 'all' before processing 'install-common'.

Signed-off-by: Olaf Hering <olaf at aepfle.de>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index a9bcab9..e1422c2 100644
--- a/Makefile
+++ b/Makefile
@@ -106,9 +106,9 @@ clean : mostly_clean
 	rm -f core */core
 	rm -f *~ contrib/*/*~ */*~
 
-install : all install-common
+install : install-common
 
-install-common :
+install-common : all
 	$(INSTALL) -d $(DESTDIR)$(BINDIR)
 	$(INSTALL) -d $(DESTDIR)$(MANDIR)/man8
 	$(INSTALL) -m 644 $(MAN)/dnsmasq.8 $(DESTDIR)$(MANDIR)/man8 
-- 
2.30.2




More information about the Dnsmasq-discuss mailing list