[Dnsmasq-discuss] [PATCH] forward.c: fix handling of truncated response

[Geert Stappers]

On Tue, Oct 01, 2024 at 09:58:10AM +0530, Rahul Thakur via Dnsmasq-discuss wrote:
> From: Rahul Thakur <rahul.thakur at iopsys.eu>
> 
> the handling of truncated reponse is broken in 2.90. The answers
> are removed before forwarding in case TC bit is set, which
> seems incorrect.
> ---
>  src/forward.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/forward.c b/src/forward.c
> index 10e7496..1ede913 100644
> --- a/src/forward.c
> +++ b/src/forward.c
> @@ -785,9 +785,6 @@ static size_t process_reply(struct dns_header *header, time_t now, struct server
>    if (header->hb3 & HB3_TC)
>      {
>        log_query(F_UPSTREAM, NULL, NULL, "truncated", 0);
> -      header->ancount = htons(0);
> -      header->nscount = htons(0);
> -      header->arcount = htons(0);
>      }
>  
>    if  (!(header->hb3 & HB3_TC) && (!bogusanswer || (header->hb4 & HB4_CD)))
> -- 
> 2.25.1
> 

The  "v2" has been seen.

IMNSHO there should be a "v3" which is the code change of "v2"
with commit message refering to the RFC that was referenced in
the discussion.

Please Cc email address '~stappers/dnsmasqmlpc at
lists.sr.ht' on sending the v3 patch to get it at
 https://lists.sr.ht/~stappers/dnsmasqmlpc/patches (mlpc:
mailinglistpatchcollector) for preventing that the patch falls through
the cracks.


Groeten
Geert Stappers
-- 
Silence is hard to parse