[Dnsmasq-discuss] [PATCH v1] Fix dependency in make install target

[Simon Kelley]

Applied. Sorry for the delay.

Cheers,

Simon.

On 10/16/23 11:02, Olaf Hering wrote:
> The make target 'install-common' expects results from the target 'all'.
> A 'make -j install' may fail because both targets are brought
> up-to-todate in parallel. As a result the final binary will not exist at
> the time 'install-common' runs, because 'all' is not yet done.
> 
> Adjust the dependencies to update 'all' before processing 'install-common'.
> 
> Signed-off-by: Olaf Hering <olaf at aepfle.de>
> ---
>   Makefile | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 48e8d3b..f279339 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -105,9 +105,9 @@ clean : mostly_clean
>   	rm -f core */core
>   	rm -f *~ contrib/*/*~ */*~
>   
> -install : all install-common
> +install : install-common
>   
> -install-common :
> +install-common : all
>   	$(INSTALL) -d $(DESTDIR)$(BINDIR)
>   	$(INSTALL) -d $(DESTDIR)$(MANDIR)/man8
>   	$(INSTALL) -m 644 $(MAN)/dnsmasq.8 $(DESTDIR)$(MANDIR)/man8
> 
> _______________________________________________
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss at lists.thekelleys.org.uk
> https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss