[Dnsmasq-discuss] [PATCH] Quieten DHCPv6 log when in static mode.

[Geert Stappers]

Hello Ian Dall,

(Cc to dnsmasq mailinglist and "patch collector")


On Sun, Mar 17, 2024 at 02:58:39PM +0100 to dnsmasq mailinglist:
> Quieten DHCPv6 log when in static mode.
> 
> When a DHCP range has a mode of "static" then the pool of dynamically
> allocated address is configured to be of zero size. DHCPv6 will still
> respond with statically defined addresses. In these cirumstances, not
> allocating an address is expected behaviour and not an error, so allow
> "no addresses available" messages to be quietened.
> 
> Signed-off-by: Ian Dall <ian at beware.dropbear.id.au>
> ---
>  src/rfc3315.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/rfc3315.c b/src/rfc3315.c
> index 400d939..6d8c4e6 100644
> --- a/src/rfc3315.c
> +++ b/src/rfc3315.c
> @@ -815,7 +815,10 @@ static int dhcp6_no_relay(struct state *state, int msg_type, unsigned char *inbu
>  	    for (c = state->context; c; c = c->current)
>  	      if (!(c->flags & CONTEXT_RA_STATELESS))
>  		{
> -		  log6_packet(state, state->lease_allocate ? "DHCPREPLY" : "DHCPADVERTISE", NULL, _("no addresses available"));
> +		  if (c->flags & CONTEXT_STATIC)
> +		    log6_quiet(state, state->lease_allocate ? "DHCPREPLY" : "DHCPADVERTISE", NULL, _("no addresses available"));
> +		  else
> +		    log6_packet(state, state->lease_allocate ? "DHCPREPLY" : "DHCPADVERTISE", NULL, _("no addresses available"));
>  		  break;
>  		}
>  	  }
> -- 
> 2.30.2
> 

<screenshot>
stappers at paddy:~/src/dnsmasq
$ curl -s https://lists.sr.ht/~stappers/dnsmasqmlpc/patches/50265/mbox | git am --3way
Applying: Quieten DHCPv6 log when in static mode.
stappers at paddy:~/src/dnsmasq
$
</screenshot>

That means that the patch still applies cleanly.

But I just have marked the patch with "NEEDS REVISION". That is to
express "long enough in the mailinglist patch collection".

If the patch is still important to you, resubmitted it.
Feel free to Cc 'Mailinglist patch collector <~stappers/dnsmasqmlpc at lists.sr.ht>'
to prevent it gets lost in the mailinglist archive. Yes, that "Cc: "
will add it to https://lists.sr.ht/~stappers/dnsmasqmlpc/patches?search=status%3Aproposed
but with new time stamps **plus** information that you still would like
to have the patch merged.


Regards
Geert Stappers
-- 
Silence is hard to parse