[Dnsmasq-discuss] dnsmasq 2.92test2: Compiler warnings

[Simon Kelley]

On 4/8/25 11:49, pedro wrote:
> Hello Simon,
> 
> Also these:
> 
> option.c: In function ‘expand_filelist’:
> option.c:5744:11: warning: ‘last’ may be used uninitialized in this 
> function [-Wmaybe-uninitialized]
>          if (last != ah1)
>             ^
> dnssec.c: In function ‘dnssec_validate_ds’:
> dnssec.c:995:22: warning: ‘rc’ may be used uninitialized in this 
> function [-Wmaybe-uninitialized]
>     int qtype, qclass, rc, i, neganswer = 0, nons = 0, servfail = 0, 
> neg_ttl = 0, found_supported = 0;
>                        ^
> TIA
> BR
> pedro
> 
> 

What compiler version are you using? It's not too difficult to convince 
yourself that both of these are false warnings, but that may be too 
subtle for older, simpler, dataflow analysis.

Either that or both me and gcc 13.3.0 (which doesn't warn on this) have 
missed something, and you have a cleverer compiler.


Simon.
>> Hello,
>>
>> could you silence the following compiler warnings?
>>
>> cache.c: In function ‘cache_recv_insert’:
>> cache.c:884:17: warning: comparison of integer expressions of
>> different signedness: ‘ssize_t’ {aka ‘int’} and ‘u32’ {aka ‘unsigned
>> int’} [-Wsign-compare]
>>    884 |           if (m > daemon->metrics[METRIC_CRYPTO_HWM])
>>        |                 ^
>> cache.c:888:17: warning: comparison of integer expressions of
>> different signedness: ‘ssize_t’ {aka ‘int’} and ‘u32’ {aka ‘unsigned
>> int’} [-Wsign-compare]
>>    888 |           if (m > daemon->metrics[METRIC_SIG_FAIL_HWM])
>>        |                 ^
>> cache.c:892:17: warning: comparison of integer expressions of
>> different signedness: ‘ssize_t’ {aka ‘int’} and ‘u32’ {aka ‘unsigned
>> int’} [-Wsign-compare]
>>    892 |           if (m > daemon->metrics[METRIC_WORK_HWM])
>>        |                 ^
>>
>> dnssec.c: In function ‘dnssec_validate_ds’:
>> dnssec.c:995:22: warning: ‘rc’ may be used uninitialized in this
>> function [-Wmaybe-uninitialized]
>>    995 |   int qtype, qclass, rc, i, neganswer = 0, nons = 0, servfail
>> = 0, neg_ttl = 0, found_supported = 0;
>>        |                      ^~
>>
>> Regards,
>> Opty
>>
>> _______________________________________________
>> Dnsmasq-discuss mailing list
>> Dnsmasq-discuss at lists.thekelleys.org.uk
>> https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
> 
> _______________________________________________
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss at lists.thekelleys.org.uk
> https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss