[Dnsmasq-discuss] [PATCH] Fix alignment issue

[Alex Landau]

--- Simon Kelley <simon at thekelleys.org.uk> wrote:

> Alex Landau wrote:
> 
> > A few compilation warnings, if you're interested... They were present in the previous
> > version too.
> > 
> > bfin-uclinux-gcc -O2 -DNO_IPV6 -DNO_TFTP -DHAVE_BROKEN_RTC -D__uClinux__ -DNO_GETTEXT
> > `echo -DNO_IPV6 -DNO_TFTP -DHAVE_BROKEN_RTC -D__uClinux__ | ../bld/pkg-wrapper
> pkg-config
> > --cflags dbus-1`  -Wall -W -c rfc1035.c
> > rfc1035.c: In function ‘questions_crc’:
> > rfc1035.c:352: warning: comparison between signed and unsigned
> > rfc1035.c: In function ‘find_pseudoheader’:
> > rfc1035.c:429: warning: comparison between signed and unsigned
> > rfc1035.c: In function ‘find_soa’:
> > rfc1035.c:512: warning: comparison between signed and unsigned
> > rfc1035.c:548: warning: comparison between signed and unsigned
> > rfc1035.c: In function ‘extract_addresses’:
> > rfc1035.c:609: warning: comparison between signed and unsigned
> > rfc1035.c:640: warning: comparison between signed and unsigned
> > rfc1035.c:715: warning: comparison between signed and unsigned
> > rfc1035.c: In function ‘check_for_bogus_wildcard’:
> > rfc1035.c:920: warning: comparison between signed and unsigned
> 
> New test release:
> 
> http://www.thekelleys.org.uk/dnsmasq/test-releases/dnsmasq-2.40test21.tar.gz
> 

The above are fixed. DNS and DHCP are also working as expected.

> should fix these. It's strange that I don't see them: I suspect
> differences   in system header files.
> 

Perhaps. I've seen that too. This cross compiler emits much more warnings than the native
compiler (of nearly the same version, i.e. 4.1.x) on Debian Etch and Fedora 7.
It is available at blackfin.uclinux.org, in case you're interested.

> > 
> > bfin-uclinux-gcc -O2 -DNO_IPV6 -DNO_TFTP -DHAVE_BROKEN_RTC -D__uClinux__ -DNO_GETTEXT
> > `echo -DNO_IPV6 -DNO_TFTP -DHAVE_BROKEN_RTC -D__uClinux__ | ../bld/pkg-wrapper
> pkg-config
> > --cflags dbus-1`  -Wall -W -c dnsmasq.c
> > dnsmasq.c: In function ‘check_dns_listeners’:
> > dnsmasq.c:848: warning: unused variable ‘p’
> > 

p is (still) unused due to NO_FORK and not NO_IPV6...

> > bfin-uclinux-gcc -O2 -DNO_IPV6 -DNO_TFTP -DHAVE_BROKEN_RTC -D__uClinux__ -DNO_GETTEXT
> > `echo -DNO_IPV6 -DNO_TFTP -DHAVE_BROKEN_RTC -D__uClinux__ | ../bld/pkg-wrapper
> pkg-config
> > --cflags dbus-1`  -Wall -W -c netlink.c
> > netlink.c: In function ‘iface_enumerate’:
> > netlink.c:122: warning: label ‘again’ defined but not used
> > netlink.c:104: warning: unused parameter ‘ipv6_callback’
> > 
> 
> These are side-effects of disabling IPV6. I think I'd rather live with
> them than add to to the #ifdef forrest.

Fair enough. After all, no-MMU and no-IPv6 may be a not so common situation.

> 
> Cheers,
> 
> Simon.
> 

Thanks,
Alex


       
____________________________________________________________________________________
Pinpoint customers who are looking for what you sell. 
http://searchmarketing.yahoo.com/