[Dnsmasq-discuss] [patch] empty empty lines

john doe johndoe65534 at mail.com
Mon Sep 30 15:35:12 BST 2019


On 9/30/2019 2:11 PM, Petr Mensik wrote:
> Hi John,
> dnsmasq is quite interesting piece of software. It is used by lot
> different kind of projects. I think noone objected dnsmasq isn't useful
> or Simon does not work on it.
> But as with everything, there is always some space for improvements.
> There is no reason why Simon should stop working on project just because
> we have seen some issues.
> Though Simon has specific code style that is unusual on different
> project. It is his decision, okay with that. Just keep the codebase
> consistent.
> When I am against forced reformatting like someone here suggested, I
> think some easy checks might be done before commiting changes. For
> example, git diff would show in red whitespaces on lines without
> anything else or after code before end of line. These are not nice and I
> would like them removed.
> I think we all understand this is open source project. We are just
> trying to make code more readable and nicer. We also offer helping hands.
> Are you sure we should stop that?
> Cheers,
> Petr
> On 9/15/19 6:32 PM, john doe wrote:
>> On 9/15/2019 5:45 PM, Geert Stappers wrote:
>>> On Sun, Sep 08, 2019 at 02:25:18PM +0200, Geert Stappers wrote:
>>>> On Sun, Sep 08, 2019 at 02:17:23PM +0200, Geert Stappers wrote:
>>>>> Made empty lines that had only spaces or tabs truely empty
>>>>> with `sed --in-place -e 's/^[ \t]*$//' src/*.c`
>>>> | $ sed --in-place -e 's/^[ \t]*$//' src/*.c
>>>> | $ git diff | wc
>>>> |   21648   76730  597015
>>>> 597015 is to big for the current settings of the mailing list.
>>>> So please use the previous posting as commit message.
>>> Or "copy and paste"  this
>>> sed --in-place -e 's/^[ \t]*$//' src/*.c
>>> git add src/*.c
>>> git commit --author "Geert Stappers <stappers at stappers.nl>" -m "empty empty lines
>>> Made empty lines that had only spaces or tabs truely empty
>>> with \`sed --in-place -e 's/^[ \t]*$//' src/*.c\`."
>>> _______________________________________________
>> Please do stop, has Simon and other has pointed out, there are no
>> reasons for Simon to change his way of working especially given the
>> outstanding work he is doing with the project.
>> --
>> John Doe
>> _______________________________________________

I have no argument with what you said above, if Simon is willing to use
'git diff --check' or using the 'pre-commit' hook that would be awsome.
The above 'sed' snippet code was to modify code already pushed and not
to help Simon improving the code consistency in the future! :)

John Doe

More information about the Dnsmasq-discuss mailing list