[Dnsmasq-discuss] [patch] empty empty lines
simon at thekelleys.org.uk
Mon Sep 30 15:50:31 BST 2019
To be clear, I have no objection to this sort of patch/suggestion.
It should be fairly clear, however, that my available time to work on
dnsmasq at the moment is limited, and stuff like this is not a priority,
and likely to be pushed to the back of the queue, possibly so far that
it never emerges again.
If we're going to do this, the first stage is probably to add hooks to
git to run expand (for tabs) and this filter on all NEW commits. Then
we won't ever have to do that again.
As that filter will make massive updates to existing code, we'll have
to take a one-time commit across the codebase to get everything fixed
once. Otherwise the filters will adding lots of extra formatting changes
to other commits as they touch files, which is not good.
So, let's come to a consensus if a one-time clean up commit across the
codebase is a price worth paying to fix the formatting issues, and if it
is, work out how to add automatic filters to git to keep things clean
afterwards. If anyone has experience of that, I'd like to hear.
On 30/09/2019 13:11, Petr Mensik wrote:
> Hi John,
> dnsmasq is quite interesting piece of software. It is used by lot
> different kind of projects. I think noone objected dnsmasq isn't useful
> or Simon does not work on it.
> But as with everything, there is always some space for improvements.
> There is no reason why Simon should stop working on project just because
> we have seen some issues.
> Though Simon has specific code style that is unusual on different
> project. It is his decision, okay with that. Just keep the codebase
> When I am against forced reformatting like someone here suggested, I
> think some easy checks might be done before commiting changes. For
> example, git diff would show in red whitespaces on lines without
> anything else or after code before end of line. These are not nice and I
> would like them removed.
> I think we all understand this is open source project. We are just
> trying to make code more readable and nicer. We also offer helping hands.
> Are you sure we should stop that?
> On 9/15/19 6:32 PM, john doe wrote:
>> On 9/15/2019 5:45 PM, Geert Stappers wrote:
>>> On Sun, Sep 08, 2019 at 02:25:18PM +0200, Geert Stappers wrote:
>>>> On Sun, Sep 08, 2019 at 02:17:23PM +0200, Geert Stappers wrote:
>>>>> Made empty lines that had only spaces or tabs truely empty
>>>>> with `sed --in-place -e 's/^[ \t]*$//' src/*.c`
>>>> | $ sed --in-place -e 's/^[ \t]*$//' src/*.c
>>>> | $ git diff | wc
>>>> | 21648 76730 597015
>>>> 597015 is to big for the current settings of the mailing list.
>>>> So please use the previous posting as commit message.
>>> Or "copy and paste" this
>>> sed --in-place -e 's/^[ \t]*$//' src/*.c
>>> git add src/*.c
>>> git commit --author "Geert Stappers <stappers at stappers.nl>" -m "empty empty lines
>>> Made empty lines that had only spaces or tabs truely empty
>>> with \`sed --in-place -e 's/^[ \t]*$//' src/*.c\`."
>> Please do stop, has Simon and other has pointed out, there are no
>> reasons for Simon to change his way of working especially given the
>> outstanding work he is doing with the project.
>> John Doe
>> Dnsmasq-discuss mailing list
>> Dnsmasq-discuss at lists.thekelleys.org.uk
More information about the Dnsmasq-discuss