[Dnsmasq-discuss] [PATCH v4] Connection track mark based DNS query filtering.

[Geert Stappers]

On Thu, Feb 18, 2021 at 12:11:55AM +0100, Etan Kissling wrote:
> On 17.02.21, 23:41, Geert Stappers" wrote:
> > > +#if defined(HAVE_CONNTRACK) && defined(HAVE_UBUS)
> >
> > One of many
> 
> > > +#  ifdef HAVE_CONNTRACK
> >
> > One of many
> 
> Sorry, I don't understand the comment for these.

The sorry should come from me.  I was way too short with text.
Thing I trying to tell is that the wish is to avoid #if
conditionals. Reason I remember is reducing the amount
of different binaries. But HAVE_CONNTRACK is already
present in current source.


> As those features need libraries that are only present when the
> corresponding defines are set, the usage code also needs to be guarded.

True


      ......
> > Do know that it is _not_ up to me to decide on this patch.
> >
> > Thing I'm saying is that it got some human attention.
> 
> Thanks for taking your time to look into it. Appreciate the comments!

;-)



Groeten
Geert Stappers


P.S.
Simon, we can't tell if you are already reviewing the patch.
In case you did, share with us your verdict.  Do know that it is
better to reject a patch than leaving the patchsubmitter in vain.
-- 
Silence is hard to parse