[Dnsmasq-discuss] [PATCH v4] Connection track mark based DNS query filtering.

Etan Kissling etan_kissling at apple.com
Fri Feb 19 21:38:39 UTC 2021



On 18.02.21, 22:10, "Dnsmasq-discuss on behalf of Geert Stappers" <dnsmasq-discuss-bounces at lists.thekelleys.org.uk on behalf of stappers at stappers.nl> wrote:

> On Thu, Feb 18, 2021 at 12:11:55AM +0100, Etan Kissling wrote:
> > On 17.02.21, 23:41, Geert Stappers" wrote:
> > > > +#if defined(HAVE_CONNTRACK) && defined(HAVE_UBUS)
> > >
> > > One of many
> >
> > Sorry, I don't understand the comment for these.
>
> The sorry should come from me.  I was way too short with text.
> Thing I trying to tell is that the wish is to avoid #if
> conditionals. Reason I remember is reducing the amount
> of different binaries. But HAVE_CONNTRACK is already
> present in current source.

No new binaries are created with this patch. The existing HAVE_CONNTRACK
symbol is used to guard accessing Netfilter connection track marks.
The existing HAVE_UBUS symbol is used to guard OpenWrt specific code.
Furthermore, even when those symbols are defined, all new code only
activates when the configuration option to enable the feature is set:
    if (option_bool(OPT_CMARK_ALST_EN))

Thanks

Etan






More information about the Dnsmasq-discuss mailing list