[Dnsmasq-discuss] Maybe another thinko in branch v2.85 master [PATCH]

[Petr Menšík]

Of course it should. Thanks! I made more copy and paste mistakes in
replacing copy and paste code than I expected.

Attached the fix and also one missing place, where it can be reused.
Checked three times for correct flags this time.

Cheers,
Petr

On 3/23/21 2:27 AM, Xingcong Li wrote:
> I reviewed this commit and found the author seems to copy-paste too quickly.
> 
> commit e10a9239e103a2f23f1e758effba624740a4842d
> 
> https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=blobdiff;f=src/forward.c;h=fcc5972cded0f4f06d72f0a3f2c82aff05f1357d;hp=8b1698bb5c263dd359e48de310214e5831983bbd;hb=e10a9239e103a2f23f1e758effba624740a4842d;hpb=51f7bc924cbcdeb09cbb83249b70c121d1ffa31e
> 
> I noticed that the calling server_test_type() in function void
> reply_query(int fd, time_t now), the 4th argument should be SERV_DO_DNSSEC.
> 
> Correct me if I'm wrong.
> Thanks!
> 
> Xingcong Li


-- 
Petr Menšík
Software Engineer
Red Hat, http://www.redhat.com/
email: pemensik at redhat.com
PGP: DFCF908DB7C87E8E529925BC4931CA5B6C9FC5CB
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Correct-missing-SERV_DO_DNSSEC-flag-add-new-spot.patch
Type: text/x-patch
Size: 1406 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20210323/b15f91ed/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20210323/b15f91ed/attachment.sig>