[Dnsmasq-discuss] Maybe another thinko in branch v2.85 master [PATCH]

Simon Kelley simon at thekelleys.org.uk
Sat Mar 27 23:17:12 UTC 2021


Patch applied. Thanks both.

Simon.


On 23/03/2021 13:38, Petr Menšík wrote:
> Of course it should. Thanks! I made more copy and paste mistakes in
> replacing copy and paste code than I expected.
> 
> Attached the fix and also one missing place, where it can be reused.
> Checked three times for correct flags this time.
> 
> Cheers,
> Petr
> 
> On 3/23/21 2:27 AM, Xingcong Li wrote:
>> I reviewed this commit and found the author seems to copy-paste too quickly.
>>
>> commit e10a9239e103a2f23f1e758effba624740a4842d
>>
>> https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=blobdiff;f=src/forward.c;h=fcc5972cded0f4f06d72f0a3f2c82aff05f1357d;hp=8b1698bb5c263dd359e48de310214e5831983bbd;hb=e10a9239e103a2f23f1e758effba624740a4842d;hpb=51f7bc924cbcdeb09cbb83249b70c121d1ffa31e
>>
>> I noticed that the calling server_test_type() in function void
>> reply_query(int fd, time_t now), the 4th argument should be SERV_DO_DNSSEC.
>>
>> Correct me if I'm wrong.
>> Thanks!
>>
>> Xingcong Li
> 
> 
> 
> _______________________________________________
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss at lists.thekelleys.org.uk
> https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
> 




More information about the Dnsmasq-discuss mailing list