[Dnsmasq-discuss] Patch with option to filter A records
Trey Sis
treysis at gmx.net
Sat Jun 5 16:20:13 UTC 2021
For some reason I didn't receive all mails from the list in my inbox, so
I'll reply to this mail. Also sorry if I mess something up. I haven't
used a mailing list in over two decades.
On 6/5/2021 17:37, Geert Stappers via Dnsmasq-discuss wrote:
> On Sat, Jun 05, 2021 at 03:34:59PM +0200, Trey Sis wrote:
>> Is there any chance for such a patch to make it into official
>> dnsmasq? Are pull-requests on github acted on? That would be my
>> preferred method, otherwise I will post the patch here.
>>
>> Cheers,
>> Treysis
>>
>> Patch:
>>
>> >From bd22a36f76e35a0dc6c8be8996056318fec96e5e Mon Sep 17 00:00:00 2001
>> From: treysis <treysis at gmx.net>
>> Date: Sat, 5 Jun 2021 15:27:26 +0200
>> Subject: [PATCH] Add option to filter A record requests
>>
>> ---
>> src/dnsmasq.h | 3 ++-
>> src/option.c | 3 +++
>> src/rfc1035.c | 11 +++++++++++
>> 3 files changed, 16 insertions(+), 1 deletion(-)
>>
> That patch did not apply cleanly. With some manual work it did apply.
> Except to see the reworked version here soon.
> Hopefully is Author left intact. (I'm about to `git send-email` a patch
> that is not mine ).
> And the original patch lacks update of the manual page,
> it is where I chip in.
>
>
> Cheers
> Geert Stappers
>
> P.S.
> https://git-send-email.io/ for instructions on email patches.
> See "Linux kernel development all over the place" in it.
Thanks for the tip. I'll have a look at that for future use. The patch
probably didn't apply because I just copy&pasted it here. The source
code is a bit inconsistent in using a mix of spaces and tabs for
indentation. Tabs probably got lost when copying.
Thanks also for taking care of the manpage! Happy to see this hopefully
land in upstream :)
Cheers,
Treysis
More information about the Dnsmasq-discuss
mailing list