[Dnsmasq-discuss] [PATCH] Two small fixes

Dominik DL6ER dl6er at dl6er.de
Sat Sep 18 18:20:28 UTC 2021


Hey Simon,

I have two small patches for dnsmasq to address two oddities I've
seen this week.

Patch 1 fixes an ambiguity with interface names when virtual
interfaces are present.
I'm not exactly sure it has no unintended side-effects, however,
it seems to be the right thing to do in my understanding of the
code. Otherwise, virtual interfaces cannot really be
distinguished from real interfaces later in the code. This may be
a problem when there is more than one virtual interface as iface-
>label will be non-zero for all of them. For instance,
warn_wild_labels() will log the same string multiple times if
more than one virtual interface is present.

Patch 2 fixes a crash I've seen on a small embedded device that
crashed when there wasn't enough memory available for allocating
a TCP packet (66 kilobytes).

Best regards,
Dominik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Check-if-allocation-of-66573-bytes-succeeded-before-.patch
Type: text/x-patch
Size: 897 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20210918/133811b8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-label-instead-of-interface-name-to-avoid-ambigui.patch
Type: text/x-patch
Size: 1839 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20210918/133811b8/attachment-0001.bin>


More information about the Dnsmasq-discuss mailing list