[Dnsmasq-discuss] [PATCH] Two small fixes

Simon Kelley simon at thekelleys.org.uk
Mon Sep 27 21:46:54 UTC 2021


On 18/09/2021 19:20, Dominik DL6ER wrote:
> Hey Simon,
> 
> I have two small patches for dnsmasq to address two oddities I've
> seen this week.
> 
> Patch 1 fixes an ambiguity with interface names when virtual
> interfaces are present.
> I'm not exactly sure it has no unintended side-effects, however,
> it seems to be the right thing to do in my understanding of the
> code. Otherwise, virtual interfaces cannot really be
> distinguished from real interfaces later in the code. This may be
> a problem when there is more than one virtual interface as iface-
>> label will be non-zero for all of them. For instance,
> warn_wild_labels() will log the same string multiple times if
> more than one virtual interface is present.

I'm still thinking about this. I have a feeling that it may not work
well on platforms other than Linux.
> 
> Patch 2 fixes a crash I've seen on a small embedded device that
> crashed when there wasn't enough memory available for allocating
> a TCP packet (66 kilobytes).
> 


A no-bainer. Patch accepted.



cheers,

Simon.

> Best regards,
> Dominik
> 




More information about the Dnsmasq-discuss mailing list