[Dnsmasq-discuss] [PATCH] RFC8520 (MUD) support in DHCP

[Simon Kelley]

Jasper,

The patch looks fine, and I'm happy to commit it. Geert's point is a 
good one; please could you supply a suitable commit message which 
describes clearly what the patch does, and includes this attribution 
information directly and not as links: the git commit will be around 
forever, the github projects may not be.

I've done a little tidying of the code, and I noticed that it further 
breaks the LUA code in src/helper.c, which was previously broken by an 
earlier commit which added a envvar but didn't cover the corresponding 
LUA arguments. I've make a separate commit to fix both those problems.


Cheers,

Simon.


Whilst

On 12/07/2022 16:50, Jasper Wiegratz wrote:
> Some important amendments to this contribution:
> 
> * the IPv4 patch is heavily inspired by OSMUD's dnsmasq fork [1]
> 
> * the IPv6 patch was created originally in my project (NAMIB) [2]
> 
> Additional authorship information is available in the mentioned commits.
> 
> Thanks.
> 
> [1]: 
> https://github.com/osmud/dnsmasq/commit/3323d59163bcb7338a9e467883f527facb8f87db 
> 
> 
> [2]: 
> https://github.com/namib-project/dnsmasq/commit/6b02ab27e1a2290a8fd9b104cf75dc268c1b15ee 
> 
> 
> 
> Am 11.07.22 um 15:18 schrieb Jasper Wiegratz:
>> Hi Simon,
>>
>> my university project for network security has been working with a 
>> fork of dnsmasq for some time now.
>>
>> I'm submitting the attached 2 patches for dnsmasq master branch to add 
>> MUD DHCP option and URL extraction. This was requested on the mailing 
>> list [1] [2].
>>
>> I'm looking forward to hearing back from you. Thanks for your time and 
>> efforts.
>>
>> Best Regards
>>
>> Jasper Wiegratz
>>
>>
>> [1] 
>> https://www.mail-archive.com/dnsmasq-discuss@lists.thekelleys.org.uk/msg12326.html 
>>
>>
>> [2] 
>> https://www.mail-archive.com/dnsmasq-discuss@lists.thekelleys.org.uk/msg12116.html 
>>
>>
>