[Dnsmasq-discuss] [PATCH] Fix --rev-server option

Dominik Derigs dl6er at dl6er.de
Fri Mar 3 17:17:54 UTC 2023


Hey Simon, CC list,

the --rev-server option is currently broken in the released
version of dnsmasq for any non-dividable-by-eight CIDR
subnets.

It got broken in commit 1db9943 when resolving upstream
servers by name was extended to --rev-server without
accounting for the fact that rev-server is a special edge-
case. Re-using one and the same upstream server for each of
the x.y.z.in-addr.arpa is actually a wanted feature and
should not be suppressed.

A very simple patch for this is attached.

The offending commit on our mirror:
https://github.com/pi-hole/dnsmasq/commit/1db9943c6879c160a5fbef885d5ceadd3668b74d

The proposed fix:
https://github.com/pi-hole/dnsmasq/pull/13

Best,
Dominik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-rev-server-option.-It-was-broken-in-1db9943c6879.patch
Type: text/x-patch
Size: 1456 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20230303/ec0e230e/attachment.bin>


More information about the Dnsmasq-discuss mailing list