[Dnsmasq-discuss] [PATCH] Fix --rev-server option

Simon Kelley simon at thekelleys.org.uk
Mon Mar 6 17:35:47 UTC 2023


Patch applied.

Cheers,

Simon.

On 03/03/2023 17:17, Dominik Derigs wrote:
> Hey Simon, CC list,
> 
> the --rev-server option is currently broken in the released
> version of dnsmasq for any non-dividable-by-eight CIDR
> subnets.
> 
> It got broken in commit 1db9943 when resolving upstream
> servers by name was extended to --rev-server without
> accounting for the fact that rev-server is a special edge-
> case. Re-using one and the same upstream server for each of
> the x.y.z.in-addr.arpa is actually a wanted feature and
> should not be suppressed.
> 
> A very simple patch for this is attached.
> 
> The offending commit on our mirror:
> https://github.com/pi-hole/dnsmasq/commit/1db9943c6879c160a5fbef885d5ceadd3668b74d
> 
> The proposed fix:
> https://github.com/pi-hole/dnsmasq/pull/13
> 
> Best,
> Dominik



More information about the Dnsmasq-discuss mailing list